Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Clean up dead APM stats consumer code #32560

Merged
merged 6 commits into from
Apr 23, 2024
Merged

[exporter/datadog] Clean up dead APM stats consumer code #32560

merged 6 commits into from
Apr 23, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Apr 19, 2024 •
edited
Loading

APMStatsConsumer and the related code path is no longer in use since #31416.
This cleanup should be a no-op and not visible to users.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 19, 2024
@github-actions github-actions bot added the exporter/datadog Datadog components label Apr 19, 2024
@songy23 songy23 changed the title [exporter/datadog] Clean up dead code [exporter/datadog] Clean up dead APM stats consumer code Apr 22, 2024
@songy23 songy23 marked this pull request as ready for review April 22, 2024 14:43
@songy23 songy23 requested a review from a team April 22, 2024 14:43
@songy23 songy23 requested a review from dmitryax as a code owner April 22, 2024 14:43
@songy23 songy23 mentioned this pull request Apr 23, 2024
Merged
1 task
@mx-psi
Copy link
Member

mx-psi commented Apr 23, 2024

@songy23 can you resolve the conflict?

@songy23
Copy link
Member Author

songy23 commented Apr 23, 2024

@mx-psi done

@songy23
Copy link
Member Author

songy23 commented Apr 23, 2024

Test failure: #32639

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Apr 23, 2024
@mx-psi mx-psi merged commit 53bf60a into open-telemetry:main Apr 23, 2024
175 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 23, 2024
@songy23 songy23 deleted the ddog-cleanup branch April 23, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@dashpole dashpole

Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol connector/datadog exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @mx-psi @dashpole