-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/elasticsearch] Replace go-elasticsearch BulkIndexer with go-docappender #32359
Merged
andrzej-stencel
merged 50 commits into
open-telemetry:main
from
carsonip:go-docappender-bulkindexer
May 9, 2024
Merged
Changes from 13 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
1ecda8e
Use go-docappender bulk indexer
carsonip 4889835
Remove go mod replace directive
carsonip d4caa07
Merge branch 'main' into go-docappender-bulkindexer
carsonip e2c4373
Use runtime.NumCPU() as default numWorkers
carsonip f518aa5
Add changelog
carsonip aed3960
Describe defaults in readme
carsonip accd2fb
worker flush should log, not return
carsonip 0784b18
Workers use receive only channel
carsonip 40d8987
Add godoc
carsonip e4accdc
Make bulkIndexerPool private
carsonip 3ceb029
Grammar
carsonip 0fcddd2
Update changelog
carsonip dde9f6c
Use go-docappender v2, accept pipeline config
carsonip 3ed5349
Use wg instead of errgroup
carsonip 03a094f
Log error returned by Add and configure client
carsonip e256d82
Use go-docappender v2.0.1
carsonip 7748722
Fix test loop variable
carsonip 926d817
Merge branch 'main' into go-docappender-bulkindexer
carsonip c6ca007
go mod tidy all
carsonip 43a2d53
Add back missing return
carsonip ad790d7
Check for closed channel without zero check
carsonip b6642b2
Fix channel closed check
carsonip 274b862
Fix import
carsonip 0ae62df
Use new go-docappender
carsonip d1e4f4f
Use 429 instead of 500 in integration test
carsonip cf342f2
Use go-docappender fix to pass integrationtest
carsonip 324efdc
Merge branch 'main' into go-docappender-bulkindexer
carsonip 057c673
Revert integration test change and wait for rebase
carsonip 7519621
Use upcoming retry.retry_on_status config
carsonip 533331c
Bump go-docappender, remove go mod replace
carsonip 0861fae
Merge branch 'main' into go-docappender-bulkindexer
carsonip 13cc9f9
Merge branch 'main' into go-docappender-bulkindexer
carsonip 1b2a018
Log document level failures
carsonip 13d35e3
Merge branch 'main' into go-docappender-bulkindexer
carsonip 6e163a7
Add back missing import
carsonip cbf5977
Bump go-docappender
carsonip ea7e5b0
go mod tidy
carsonip 92ee227
Merge branch 'main' into go-docappender-bulkindexer
carsonip d9886c1
Update changelog
carsonip fd85db1
Merge branch 'main' into go-docappender-bulkindexer
carsonip 69f8b59
Fix conflict in go.sum
carsonip 3225676
Merge branch 'main' into go-docappender-bulkindexer
carsonip e63d855
Merge branch 'main' into go-docappender-bulkindexer
carsonip 8bad25c
Merge branch 'main' into go-docappender-bulkindexer
carsonip 8106bfa
Merge branch 'main' into go-docappender-bulkindexer
carsonip 336b3c5
Update exporter/elasticsearchexporter/elasticsearch_bulk.go
carsonip fd1b4c7
Update exporter/elasticsearchexporter/elasticsearch_bulk.go
carsonip 43ed76d
Use gzip.NoCompression for readability
carsonip 2293b53
Merge branch 'main' into go-docappender-bulkindexer
carsonip 6402cd4
Remove compression level config
carsonip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: elasticsearchexporter | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Replace go-elasticsearch BulkIndexer with go-docappender | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [32378] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | | ||
Replace go-elasticsearch BulkIndexer with go-docappender for a bulk indexer that has flush control. | ||
This will enable exporterhelper batch sender reliability fixes later. | ||
As a result of this change, there are minor differences in flush behavior and logging. | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [user] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[to reviewer] There is no change in practice and the README was wrong. The number came from https://github.com/elastic/go-elasticsearch/blob/7.17/esutil/bulk_indexer.go#L204