Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/clickhouse] Default async_insert to true. Added related config option. #32340

Closed
wants to merge 8 commits into from
Closed

[exporter/clickhouse] Default async_insert to true. Added related config option. #32340

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eb2846b
Enable async inserts by default. Add async_insert config option
SpencerTorres Apr 12, 2024
3c29f65
Update SQL syntax highlighting in README
SpencerTorres Apr 12, 2024
c86cb3d
update changelog
SpencerTorres Apr 12, 2024
de5e454
Fix `make checkapi` for config.go exports
SpencerTorres Apr 12, 2024
c50e222
update changelog to breaking change
SpencerTorres Apr 12, 2024
59265ee
Merge remote-tracking branch 'upstream/main' into config-async-inserts
SpencerTorres Apr 12, 2024
8b97159
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
SpencerTorres Apr 13, 2024
55db013
nits: update changelog, readme, and add test
SpencerTorres Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update changelog to breaking change
  • Loading branch information
@SpencerTorres
SpencerTorres committed Apr 12, 2024
commit c50e222cbe7fb04584d1fc092e1cc80ac6ad20f4
4 changes: 3 additions & 1 deletion .chloggen/clickhouse-default-async-insert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: exporter/clickhouse
Expand All @@ -22,6 +22,8 @@ subtext: |
Keep in mind this setting is added since the exporter now sets it to default.
Async insert and its related settings can still be defined in `endpoint` and `connection_params`, which take priority over the new config option.

While this change won't immediately break deployments, it is a change that should be highlighted.

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
Expand Down