Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/elasticsearch] Update README #32221

Merged
merged 10 commits into from
Apr 15, 2024
Merged

[exporter/elasticsearch] Update README #32221

merged 10 commits into from
Apr 15, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Apr 8, 2024 •
edited
Loading

Description:

Correct some errors and add more details.

No functional change, no changelog needed.

@carsonip
Update readme
f9d400c 
Correct some errors and add more details.
@carsonip carsonip requested review from a team and TylerHelmuth April 8, 2024 15:04
crobert-1
crobert-1 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

exporter/elasticsearchexporter/README.md Outdated Show resolved Hide resolved
exporter/elasticsearchexporter/README.md Outdated Show resolved Hide resolved
@crobert-1 crobert-1 added Skip Changelog PRs that do not require a CHANGELOG.md entry documentation Improvements or additions to documentation labels Apr 8, 2024
carsonip and others added 2 commits April 8, 2024 17:38
@carsonip @crobert-1
Update exporter/elasticsearchexporter/README.md
e0aac08 
Co-authored-by: Curtis Robert <crobert@splunk.com>
@carsonip @crobert-1
Update exporter/elasticsearchexporter/README.md
94566d6 
Co-authored-by: Curtis Robert <crobert@splunk.com>
ycombinator
ycombinator approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carsonip!

@crobert-1
Copy link
Member

I filed #32286 for the failing unit test on arm, it's unrelated to this change.

@carsonip carsonip mentioned this pull request Apr 11, 2024
Closed
6 tasks
@carsonip
Copy link
Contributor Author

@crobert-1 thanks, the tests are passing now

@JaredTan95
Copy link
Member

close #32344

@carsonip
Copy link
Contributor Author

close #32344

I think #32344 is more than a documentation fix which is out of scope of this PR #32221 . I've elaborated in the issue.

@TylerHelmuth TylerHelmuth merged commit 4501d0f into open-telemetry:main Apr 15, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 15, 2024
@carsonip carsonip mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@JaredTan95 JaredTan95 JaredTan95 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@codeboten codeboten codeboten approved these changes

@ycombinator ycombinator ycombinator approved these changes

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
documentation Improvements or additions to documentation exporter/elasticsearch Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.99.0
Development

Successfully merging this pull request may close these issues.
7 participants
@carsonip @crobert-1 @JaredTan95 @ycombinator @codeboten @TylerHelmuth @MovieStoreGuy