Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/exceptions] copy span attributes to generate logs from exceptions #31835

Merged

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Mar 19, 2024

Description: In #24410 we discussed the idea of making configurable the list of span attributes to copy
over to generated logs. By default only HTTP were copied. This PR changes the default behavior to copy
all span attributes and recommend to use transformprocessor to remove all unwanted attributes.

Link to tracking Issue: Resolves #24410

Documentation: Clarified in docs which attributes are copied.

@marctc marctc requested a review from jpkrohling as a code owner March 19, 2024 10:36
@marctc marctc requested a review from a team March 19, 2024 10:36
@marctc
Copy link
Contributor Author

marctc commented Mar 19, 2024

cc @crobert-1

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the PR description to have the word Resolves before the related issue number?

Link to tracking Issue: Resolves #24410

This will allow our CI to automatically close the issue when this gets merged.

connector/exceptionsconnector/README.md Outdated Show resolved Hide resolved
Co-authored-by: Curtis Robert <crobert@splunk.com>
@dmitryax dmitryax merged commit cc17c28 into open-telemetry:main Mar 27, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector/exceptions] Make list of collected HTTP attributes configurable
4 participants