-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/kafka]Decide the Kafka topic based on the value of the attribute. #31809
Conversation
6e70532
to
1148f19
Compare
Co-authored-by: Curtis Robert <crobert@splunk.com>
…llector-contrib into attribute-topic
@crobert-1 |
LGTM, thanks for your making all of the updates, and for your contribution here @pyama86! |
Co-authored-by: Curtis Robert <crobert@splunk.com>
@crobert-1 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Co-authored-by: Curtis Robert <crobert@splunk.com>
@pyama86 looks like the linter is upset
|
…llector-contrib into attribute-topic
…llector-contrib into attribute-topic
Thank you for your appreciation of our daily contributions and support to me. |
Description:
I've implemented the feature based on the discussion in the referenced issue. I'm assuming it will suffice in most cases if the text attributes are available, so I haven't planned for arrays or maps.
Link to tracking Issue:
Fixes #31178
Testing:
I've implemented unit tests. For the tests related to kafka_exporter, I followed the existing implementation, but I find it somewhat redundant. If it's okay, I'd like to switch to table-driven tests.
Documentation:
After the discussion in the PR, I believe the final implementation will be determined, so I'll add documentation once we have a clearer idea of the direction.