Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/deltotocumulative] Fix lint failure #31685

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

crobert-1
Copy link
Member

Description:

#31488 was recently merged and has broken build-and-test for all builds due to a lint failure. It looks like two PRs were worked on in parallel, the aforementioned one, as well as #31625. #31625 renamed exp to stale, but the most recently merged PR was referencing the original exp variable.

This is an unreleased component, and is simply fixing a bug, so I don't think this should have a changelog.

@crobert-1 crobert-1 requested review from a team and bryan-aguilar March 11, 2024 16:23
@crobert-1 crobert-1 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 11, 2024
@jpkrohling jpkrohling merged commit dea26fb into open-telemetry:main Mar 11, 2024
147 of 148 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 11, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

open-telemetry#31488
was recently merged and has broken `build-and-test` for all builds due
to a lint failure. It looks like two PRs were worked on in parallel, the
aforementioned one, as well as
open-telemetry#31625.
open-telemetry#31625 renamed `exp` to `stale`, but the most recently merged PR was
referencing the original `exp` variable.

This is an unreleased component, and is simply fixing a bug, so I don't
think this should have a changelog.
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

open-telemetry#31488
was recently merged and has broken `build-and-test` for all builds due
to a lint failure. It looks like two PRs were worked on in parallel, the
aforementioned one, as well as
open-telemetry#31625.
open-telemetry#31625 renamed `exp` to `stale`, but the most recently merged PR was
referencing the original `exp` variable.

This is an unreleased component, and is simply fixing a bug, so I don't
think this should have a changelog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/deltatocumulative Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants