Improvements to the awsprometheusremotewriteexporter #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improvements to language and formatting - Providing a realistic workspace URL - Removing sending_queue due to lack of support - aws_auth.service has to be always "aps", removing it from documentation - Adding a note that aws_auth.region has to match the workspace region - Documenting aws_auth.role_arn
|
cc @odeke-em |
odeke-em
approved these changes
Apr 17, 2021
|
This change relies on open-telemetry/opentelemetry-collector#2951. |
Codecov Report
@@ Coverage Diff @@
## main #3158 +/- ##
=======================================
Coverage ? 91.66%
=======================================
Files ? 479
Lines ? 23313
Branches ? 0
=======================================
Hits ? 21369
Misses ? 1447
Partials ? 497
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Removed the dependency to open-telemetry/opentelemetry-collector#2951, this is ready for review. |
tigrannajaryan
approved these changes
Apr 19, 2021
pmatyjasek-sumo
pushed a commit
to pmatyjasek-sumo/opentelemetry-collector-contrib
that referenced
this pull request
Apr 28, 2021
…3158) - Improvements to language and formatting - Providing a realistic workspace URL - Removing sending_queue due to lack of support - aws_auth.service has to be always "aps", removing it from documentation - Adding a note that aws_auth.region has to match the workspace region - Documenting aws_auth.role_arn
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-collector#2951