Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config option to use spanner_sys_reader fgac role #31497

Closed
wants to merge 11 commits into from

Conversation

maduris
Copy link

@maduris maduris commented Feb 29, 2024

Description: adding an option to enable using Spanner fine grained role "spanner_sys_role" to read sys tables from spanner databases

Link to tracking Issue:

Testing:

Documentation:

This role already has the read permissions on the spanner sys tables
https://cloud.google.com/spanner/docs/fgac-system-roles#spanner_sys_reader

The service account that the receiver uses need to still grant the IAM roles following the guide
https://cloud.google.com/spanner/docs/configure-fgac#grant-fgac-role

@maduris maduris requested review from a team and TylerHelmuth February 29, 2024 01:39
Copy link

linux-foundation-easycla bot commented Feb 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@krzko
Copy link

krzko commented Mar 2, 2024

Just as a heads up, we've build a custom collector and validated that this works in our nonprod ennvironments, we can see the spanner metrics coming through

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 27, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 11, 2024
@krzko
Copy link

krzko commented Apr 22, 2024

Can we please keep this opened, we're wanting FGAC support to be added to the Spanner Receiver

@TylerHelmuth TylerHelmuth reopened this Apr 22, 2024
@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 8, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants