Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/azureeventhub] remove continue from timestamp parse failure #31245

Closed
wants to merge 16 commits into from

Conversation

nslaughter
Copy link
Contributor

@nslaughter nslaughter commented Feb 13, 2024

Description:

Link to tracking Issue:

Testing:
Analyzed log records with and without this change.

Documentation:

@nslaughter nslaughter marked this pull request as ready for review February 14, 2024 02:54
@nslaughter nslaughter requested a review from a team February 14, 2024 02:54
@nslaughter nslaughter changed the title remove continue from timestamp parse failure [receiver/azureeventhub] remove continue from timestamp parse failure Feb 14, 2024
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cparkins
Copy link
Contributor

@nslaughter - If this is standard practice elsewhere, I think it makes sense. I intentionally skipped these records because they are really hard to find in Splunk. Maybe it makes sense to add a warning? I'll look at other receivers and see what they do. What do you think @atoulme?

@nslaughter
Copy link
Contributor Author

nslaughter commented Feb 14, 2024

per comments of @cparkins

Changed behavior so we set Timestamp if we receive a parseable time from Azure and we always set ObservedTimestamp per description of the field in the data model.

Added the option to IgnoreObservedTimestamp in test as we now set the observed timestamp to code observed time, per field description in logs data model; however that breaks test expectation that ALL fields match test record.

And noted I need to stop force pushing, so I don't disappear the comments.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 2, 2024
@github-actions github-actions bot removed the Stale label Mar 5, 2024
@nslaughter
Copy link
Contributor Author

hi @dashpole, I have an approving review from a codeowner. However, this may not show it as he wasn't a codeowner when the PR began? ... So I'm pinging. Hoping you can help getting this merged as assignee. Thank you!

pkg/translator/azure/resourcelogs_to_logs.go Outdated Show resolved Hide resolved
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 30, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 13, 2024
@cparkins
Copy link
Contributor

cparkins commented May 6, 2024

I'd like to see these changes get integrated. Can we get this reopened? I believe we have users that are experiencing this issue and it would be good to get more information. I believe these changes are good in general anyway.

@atoulme - Can you open this back up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants