-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog/connector] Create a simplified Trace to Trace connector #31026
Merged
mx-psi
merged 7 commits into
open-telemetry:main
from
dineshg13:dinesh.gurumurthy/fix-connector
Feb 5, 2024
Merged
[datadog/connector] Create a simplified Trace to Trace connector #31026
mx-psi
merged 7 commits into
open-telemetry:main
from
dineshg13:dinesh.gurumurthy/fix-connector
Feb 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshg13
changed the title
Dinesh.gurumurthy/fix connector
Datadog connector Trace to Trace connector
Feb 4, 2024
dineshg13
changed the title
Datadog connector Trace to Trace connector
[datadog/connector] Create a simplified Trace to Trace connector
Feb 4, 2024
mx-psi
reviewed
Feb 5, 2024
songy23
reviewed
Feb 5, 2024
mx-psi
approved these changes
Feb 5, 2024
songy23
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Datadog Connector is creating two instances of Trace Agent, one in the trace-to-metrics pipeline and another in the traces-to-traces pipeline. The PR separates the trace-to-trace connector, simplifying the logic, this avoid un-necessary serialization.
Link to tracking Issue:
#30828
#30487
Testing:
Documentation: