Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/signalfx] Accept otlp metrics #31008

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

jinja2
Copy link
Contributor

@jinja2 jinja2 commented Feb 1, 2024

Description:

Accept OTLP payloads on /v2/datapoint api of the SignalFx receiver

Link to tracking Issue: #26298

Testing: Updated tests

Documentation:

@jinja2 jinja2 requested a review from dmitryax as a code owner February 1, 2024 18:59
@jinja2 jinja2 requested a review from a team February 1, 2024 18:59
@jinja2 jinja2 marked this pull request as draft February 1, 2024 19:00
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good to me. just minor code comments

receiver/signalfxreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/signalfxreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/signalfxreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/signalfxreceiver/receiver.go Outdated Show resolved Hide resolved
@jinja2 jinja2 marked this pull request as ready for review February 9, 2024 03:38
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits. Otherwise, LGTM

receiver/signalfxreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/signalfxreceiver/receiver.go Outdated Show resolved Hide resolved
@dmitryax dmitryax merged commit c0ce352 into open-telemetry:main Feb 9, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 9, 2024
vasireddy99 added a commit to vasireddy99/opentelemetry-collector-contrib that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants