Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/journald]: add support for all configuration #30971

Merged

Conversation

meridional
Copy link
Contributor

Description:
This commit adds support for all to journald
receiver, which allows full output, including
unprintable characters and lines that are too long.

Link to tracking Issue: #30920

Testing: unit test and manual test.

Documentation: receiver/journaldreceiver/README.md and pkg/stanza/docs/operators/journald_input.md

@meridional meridional requested a review from a team February 1, 2024 03:05
Copy link

linux-foundation-easycla bot commented Feb 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: meridional / name: Ye Ji (5f72471)

Copy link
Member

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@djaglowski
Copy link
Member

LGTM as well. Please sign the CLA and we can get this merged.

@meridional meridional force-pushed the add-all-to-journald-receiver branch from e30f866 to 4db6f04 Compare February 1, 2024 21:28
This commit adds support for `all` to journald
receiver, which allows full output, including
unprintable characters and lines that are too long.
@meridional meridional force-pushed the add-all-to-journald-receiver branch from 4fd312d to 5f72471 Compare February 2, 2024 02:41
@meridional
Copy link
Contributor Author

Thanks for reviewing. I've signed the CLA.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meridional. I've restarted CI and will merge this as soon as it's all green.

@djaglowski djaglowski merged commit b25e9de into open-telemetry:main Feb 2, 2024
138 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants