[chore][receiver/haproxy] Fix scraperhelper name #30925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-bradley
approved these changes
Jan 31, 2024
atoulme
approved these changes
Jan 31, 2024
mx-psi
added a commit
that referenced
this pull request
Feb 1, 2024
**Description:** Similar to #30917 and #30925, the ID was empty before. **Link to tracking Issue:** This is needed to make contrib tests pass on open-telemetry/opentelemetry-collector#9414
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
**Description:** Same as open-telemetry#30917, before this change an empty name could be passed to the scraperhelper. I think this is the only other instance of this pattern **Link to tracking Issue**: This is needed to make contrib tests pass on open-telemetry/opentelemetry-collector/pull/9414
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
**Description:** Similar to open-telemetry#30917 and open-telemetry#30925, the ID was empty before. **Link to tracking Issue:** This is needed to make contrib tests pass on open-telemetry/opentelemetry-collector#9414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Same as #30917, before this change an empty name could be passed to the scraperhelper.
I think this is the only other instance of this pattern
Link to tracking Issue: This is needed to make contrib tests pass on open-telemetry/opentelemetry-collector/pull/9414