[chore] Do more steps in parallel in build-and-test workflow #30891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
approved these changes
Jan 30, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…lemetry#30891) The build-and-test workflow takes a long time. Part of the issue is that we spend a lot of time waiting for long jobs, such as integration tests, to finish before moving onto more long jobs. This PR attempts to parallelize more steps by removing some existing ordering we've restricted ourselves to. Specifically this moves the cross-compile chain to start in parallel with the unit tests, lint, and integration tests. My reasoning is that if a unit tests or lint is bad it will still get caught and we don't need unit tests to pass to attempt to compile the code. I have update the publish-check step to still depend on all these steps. Related to open-telemetry#30880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The build-and-test workflow takes a long time. Part of the issue is that we spend a lot of time waiting for long jobs, such as integration tests, to finish before moving onto more long jobs.
This PR attempts to parallelize more steps by removing some existing ordering we've restricted ourselves to. Specifically this moves the cross-compile chain to start in parallel with the unit tests, lint, and integration tests. My reasoning is that if a unit tests or lint is bad it will still get caught and we don't need unit tests to pass to attempt to compile the code. I have update the publish-check step to still depend on all these steps.
Link to tracking Issue:
Related to #30880