Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/datadog] Add trace configs that mirror datadog exporter #30787

Merged
merged 18 commits into from
Jan 30, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Jan 25, 2024

No description provided.

@songy23 songy23 marked this pull request as ready for review January 25, 2024 21:40
@songy23 songy23 requested a review from a team January 25, 2024 21:40
connector/datadogconnector/connector.go Outdated Show resolved Hide resolved
connector/datadogconnector/config.go Show resolved Hide resolved
connector/datadogconnector/config.go Show resolved Hide resolved
Copy link
Member

@dineshg13 dineshg13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Can we add an example yaml using a config?

connector/datadogconnector/connector.go Show resolved Hide resolved
@github-actions github-actions bot added the exporter/datadog Datadog components label Jan 29, 2024
mx-psi
mx-psi previously approved these changes Jan 30, 2024
connector/datadogconnector/README.md Outdated Show resolved Hide resolved
connector/datadogconnector/config.go Show resolved Hide resolved
connector/datadogconnector/config.go Outdated Show resolved Hide resolved
connector/datadogconnector/config.go Outdated Show resolved Hide resolved
connector/datadogconnector/config.go Outdated Show resolved Hide resolved
connector/datadogconnector/examples/config.yaml Outdated Show resolved Hide resolved
connector/datadogconnector/examples/config.yaml Outdated Show resolved Hide resolved
@mx-psi mx-psi dismissed their stale review January 30, 2024 09:31

Comments need addressing

songy23 and others added 5 commits January 30, 2024 08:23
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@mx-psi mx-psi merged commit 9b4caa8 into open-telemetry:main Jan 30, 2024
85 checks passed
@mx-psi mx-psi deleted the ddconnector-config branch January 30, 2024 16:35
@github-actions github-actions bot added this to the next release milestone Jan 30, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants