Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexer metrics ep2 for splunkenterprisereceiver #30757

Merged
merged 49 commits into from
Feb 14, 2024
Merged

Indexer metrics ep2 for splunkenterprisereceiver #30757

merged 49 commits into from
Feb 14, 2024

Conversation

greatestusername
Copy link
Contributor

@greatestusername greatestusername commented Jan 24, 2024 •
edited
Loading

Description:
Adds additional indexer metrics to Splunk Enterprise receiver obtained from ad-hoc searches against Indexer or Cluster Manager instances.

Disables by default API endpoint searches that only return results for the specific instance which is having its API called. These can be re-enabled in config if those metrics are specifically required.

Generated tests and docs for these additional metrics

Link to tracking Issue: 30704

Testing: Tests generated with mdatagen

Documentation: Documentation generated with mdatagen

@greatestusername greatestusername requested a review from a team January 24, 2024 17:31
@greatestusername greatestusername marked this pull request as draft January 24, 2024 17:32
@greatestusername greatestusername marked this pull request as ready for review January 24, 2024 17:53
@greatestusername greatestusername marked this pull request as draft January 24, 2024 17:55
@greatestusername greatestusername marked this pull request as ready for review January 24, 2024 18:29
@atoulme
Copy link
Contributor

atoulme commented Jan 25, 2024

Good stuff! Just some nits on metrics. I didn't check the scraper changes yet.

@greatestusername
Copy link
Contributor Author

2 failures outside of my control in current tests:

--- FAIL: TestGetNewToken (0.01s)
    --- FAIL: TestGetNewToken/Bad_payload_returned (0.01s)
        testing.go:1465: race detected during execution of test
    testing.go:1465: race detected during execution of test
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver	0.303s
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver/internal/mocks	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver/internal/models	[no test files]
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/bigipreceiver/internal/metadata	1.098s
FAIL

Wil re-run on next base mergeupdate

@greatestusername
Copy link
Contributor Author

le sigh :D

2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60516: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60518: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60534: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60544: remote error: tls: bad certificate
2024/02/08 15:20:07 http: TLS handshake error from 127.0.0.1:60554: write tcp 127.0.0.1:43767->127.0.0.1:60554: use of closed network connection
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	coverage: 88.4% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/signalfxexporter	8.832s

@greatestusername
Copy link
Contributor Author

one more time!

[2024-02-08T16:19:29.200Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
[2024-02-08T16:19:29.200Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 503 - upstream connect error or disconnect/reset before headers. reset reason: connection failure
    at main (/snapshot/repo/dist/src/index.js)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@greatestusername
Copy link
Contributor Author

@jpkrohling or @TylerHelmuth anything else I need to do on this PR? Let me know! Thanks!

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Feb 14, 2024
@TylerHelmuth TylerHelmuth merged commit 1aa1d0d into open-telemetry:main Feb 14, 2024
147 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 14, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
@greatestusername @XinRanZhAWS
Indexer metrics ep2 for splunkenterprisereceiver (open-telemetry#30757)
547d70d 
**Description:** 
Adds additional indexer metrics to Splunk Enterprise receiver obtained
from ad-hoc searches against Indexer or Cluster Manager instances.

Disables by default API endpoint searches that only return results for
the specific instance which is having its API called. These can be
re-enabled in config if those metrics are specifically required.

Generated tests and docs for these additional metrics

**Link to tracking Issue:**
[30704](open-telemetry#30704)

**Testing:** Tests generated with mdatagen

**Documentation:** Documentation generated with mdatagen
@crobert-1 crobert-1 mentioned this pull request Mar 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme left review comments

@shalper2 shalper2 shalper2 approved these changes

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

Assignees

@jpkrohling jpkrohling

@TylerHelmuth TylerHelmuth

@andrzej-stencel andrzej-stencel

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/splunkenterprise
Projects
None yet
Milestone
v0.95.0
Development

Successfully merging this pull request may close these issues.
7 participants
@greatestusername @atoulme @MovieStoreGuy @shalper2 @jpkrohling @TylerHelmuth @andrzej-stencel