[cmd/opampsupervisor] Support AcceptsRestartCommand Capability
#30694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
|
I will add the CHANGELOG entry and mark it ready for review. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…llector-contrib into issue-21077
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@evan-bradley / @tigrannajaryan can you reopen this? |
evan-bradley
approved these changes
Apr 16, 2024
|
I see that the test is failing. I will fix that. I suspect the fact that the restart command is not distinguished from the unexpected restart might be the reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add restart command support to opamp supervisor capabilities.
Fixes #21077
Link to tracking Issue: #21077
Testing: Added integration test
Documentation: