-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[*/datadog] Bump opentelemetry-mapping-go to v0.13.0 #30680
Conversation
rg v0.11.0 --glob '*.mod' -l | xargs sd '(github.com/DataDog/opentelemetry-mapping-go/.*) v0.11.0' '$1 v0.13.0' make gotidy
dd24e1e
to
8cf7e01
Compare
@@ -4,15 +4,15 @@ go 1.20 | |||
|
|||
require ( | |||
github.com/DataDog/agent-payload/v5 v5.0.102 | |||
github.com/DataDog/datadog-agent/pkg/proto v0.50.2 | |||
github.com/DataDog/datadog-agent/pkg/proto v0.52.0-devel | |||
github.com/DataDog/datadog-agent/pkg/trace v0.50.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do you want to upgrade this one to v0.52.0-devel
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't explicitly bump the other one, it was just because of https://github.com/DataDog/opentelemetry-mapping-go/blob/81d9650bebbbcff44cec39ac97fd9c46420c32bc/pkg/otlp/metrics/go.mod#L6
But it makes sense to bump the rest as well, let me do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6b4be71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this surfaced some problem: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7585607691/job/20662004468?pr=30680#step:9:166
I'm not sure whether we want to resolve that in this PR or revert the dep upgrade, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert the bump and open a separate PR for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
This reverts commit 6b4be71.
…30680) - Bump opentelemetry-mapping-go to v0.13.0 - Amend gohai to adapt to new types - Add changelog note
Description: