Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]add integration test #30279

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 3, 2024

Add a simple integration test for the filestats receiver.

@atoulme atoulme requested review from a team and mx-psi January 3, 2024 21:31
@atoulme atoulme force-pushed the filestats_integration_test branch from 1109ded to 5ea42af Compare January 3, 2024 21:36
@atoulme atoulme force-pushed the filestats_integration_test branch from 5ea42af to 2156646 Compare January 3, 2024 21:52
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I don't see the filestats receiver mentioned on these logs https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/7402775859/job/20141420670?pr=30279 Is the test running? If so, where?

@atoulme
Copy link
Contributor Author

atoulme commented Jan 4, 2024

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure why I was not able to Ctrl+F it yesterday. LGTM!

@mx-psi mx-psi merged commit 58b898a into open-telemetry:main Jan 5, 2024
85 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 5, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
Add a simple integration test for the filestats receiver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants