Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza][receiver/filelog] fix panic when upgrading from v0.71.0 #30236

Merged
merged 4 commits into from
Jan 10, 2024
Merged

[pkg/stanza][receiver/filelog] fix panic when upgrading from v0.71.0 #30236

merged 4 commits into from
Jan 10, 2024

Conversation

andrzej-stencel
Copy link
Member

@andrzej-stencel andrzej-stencel commented Dec 29, 2023 •
edited
Loading

Fixes #30235

@andrzej-stencel andrzej-stencel mentioned this pull request Dec 29, 2023
Closed
@hughesjj
Copy link
Contributor

hughesjj commented Jan 2, 2024

FWIW, LGTM, and I think you can add [chore] to the title to avoid the issue with chgloggen that's firing. I'm of the belief this is a [bug] via make chlog-new though.

@andrzej-stencel andrzej-stencel marked this pull request as ready for review January 9, 2024 17:32
@andrzej-stencel andrzej-stencel requested a review from a team January 9, 2024 17:32
@codeboten
Copy link
Contributor

@astencel-sumo looks like some tests need fixing

@andrzej-stencel andrzej-stencel added the ready to merge Code review completed; ready to merge by maintainers label Jan 10, 2024
@djaglowski djaglowski merged commit e955822 into open-telemetry:main Jan 10, 2024
90 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 10, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
@andrzej-stencel @cparkins
[pkg/stanza][receiver/filelog] fix panic when upgrading from v0.71.0 (
683234a 
open-telemetry#30236)

Fixes
open-telemetry#30235

---------

Co-authored-by: Alex Boten <aboten@lightstep.com>
@andrzej-stencel andrzej-stencel deleted the fix-stanza-panic branch January 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@hughesjj hughesjj hughesjj approved these changes

@djaglowski djaglowski djaglowski approved these changes

Assignees

@codeboten codeboten

Labels
pkg/stanza ready to merge Code review completed; ready to merge by maintainers receiver/filelog
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging this pull request may close these issues.

[pkg/stanza][receiver/filelog] panic: assignment to entry in nil map when upgrading from v0.71.0 to v0.91.0
4 participants
@andrzej-stencel @hughesjj @codeboten @djaglowski