[processor/resourcedetection]: Populate "aws.ecs.task.id" property for ECS Tasks (#8274) #29602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
mkielar
changed the title
mkielar
changed the title
songy23
reviewed
Dec 4, 2023
mkielar
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
atoulme,
jmacd,
dmitryax,
codeboten,
fatsheep9146,
jpkrohling,
TylerHelmuth,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
jsuereth and
arminru
as code owners
mx-psi
reviewed
Dec 5, 2023
There was a problem hiding this comment.
aws.ecs.task.id is not specified in the semantic conventions https://github.com/open-telemetry/semantic-conventions/blob/v1.23.1/docs/resource/cloud-provider/aws/ecs.md. While this is not a hard requirement, it would greatly help in reviewing this PR and ensuring the value on this attributes matches what the awsefmexporter and other present or future components expect. Would you be willing to file a PR on semantic-conventions first?
mkielar
added a commit
to mkielar/semantic-conventions
that referenced
this pull request
Dec 9, 2023
Added `aws.ecs.task.id`, to reflect changes introduced by [#29062][pr] Also, fixed description for `aws.ecs.task.arn`, as it does not reflect TaskDefinition ARN (as was incorrectly stated), but the ARN of the running ECS Task. [pr]: open-telemetry/opentelemetry-collector-contrib#29602
mkielar
added a commit
to mkielar/semantic-conventions
that referenced
this pull request
Dec 9, 2023
Added `aws.ecs.task.id`, to reflect changes introduced by [#29062][pr] Also, fixed description for `aws.ecs.task.arn`, as it does not reflect TaskDefinition ARN (as was incorrectly stated), but the ARN of the running ECS Task. [pr]: open-telemetry/opentelemetry-collector-contrib#29602
mkielar
added a commit
to mkielar/semantic-conventions
that referenced
this pull request
Dec 9, 2023
Added `aws.ecs.task.id`, to reflect changes introduced by [#29062][pr] Also, fixed description for `aws.ecs.task.arn`, as it does not reflect TaskDefinition ARN (as was incorrectly stated), but the ARN of the running ECS Task. [pr]: open-telemetry/opentelemetry-collector-contrib#29602
3 tasks
|
Can you add a changelog note? You can use |
mx-psi
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
LGTM. Would like someone from AWS (@bryan-aguilar ? @Aneurysm9 ?) to take a look at this before we merge
bryan-aguilar
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
resourcedetectionprocessor now populatesaws.ecs.task.idproperty (in addition to otheraws.ecs.task.*properties). This simplifies configuration of
awsemfexporter, which internally searches foraws.ecs.task.idproperty when using
TaskIdplaceholder inloggroup/logstreamname template.Link to tracking Issue: #8274
Testing: ECS Task ARNs come in two versions. In the old one, the last part of the ARN contains only the
task/<task-id>. In the new one, it containstask/cluster-name/task-id. Implementation and Unit Tests have been added to handle both cases.Documentation:
README.mdnow also mentionsaws.ecs.task.idas inferred property for ECS.