Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gendependabot #2956

Merged
merged 1 commit into from
Apr 1, 2021
Merged

fix gendependabot #2956

merged 1 commit into from
Apr 1, 2021

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Apr 1, 2021

This was changed in aa3a2c5 but I don't understand why (@aabmass). Without this change it resulted in the output being:

-e # File generated by "make gendependabot"; DO NOT EDIT.

version: 2
updates:
-e   - package-ecosystem: "gomod"
    directory: "/"
    schedule:
      interval: "weekly"
-e   - package-ecosystem: "gomod"
    directory: "/exporter/alibabacloudlogserviceexporter"
    schedule:
      interval: "weekly"
-e   - package-ecosystem: "gomod"
    directory: "/exporter/awsemfexporter"
    schedule:
      interval: "weekly"
-e   - package-ecosystem: "gomod"
    directory: "/exporter/awskinesisexporter"
    schedule:
      interval: "weekly"
-e   - package-ecosystem: "gomod"
    directory: "/exporter/awsprometheusremotewriteexporter"
    schedule:
      interval: "weekly"
-e   - package-ecosystem: "gomod"
    directory: "/exporter/awsxrayexporter"
...

@jrcamp jrcamp requested review from bogdandrutu, aabmass and a team April 1, 2021 01:07
@jrcamp jrcamp mentioned this pull request Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2956 (e4cdce7) into main (92c8edd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2956   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         464      464           
  Lines       22860    22860           
=======================================
  Hits        20929    20929           
  Misses       1438     1438           
  Partials      493      493           
Flag Coverage Δ
integration 69.02% <ø> (ø)
unit 90.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c8edd...e4cdce7. Read the comment docs.

This was changed in aa3a2c5 which fixed Ubuntu but broke Mac.
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running Debian with echo from GNU coreutils. Curious what OS and echo you have @jrcamp

@bogdandrutu bogdandrutu merged commit a835321 into open-telemetry:main Apr 1, 2021
@jrcamp jrcamp deleted the dep branch April 1, 2021 22:12
@jrcamp
Copy link
Contributor Author

jrcamp commented Apr 1, 2021

@aabmass I'm on Mac so it's BSD echo from 2003. 😂

pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
This was changed in aa3a2c5 which fixed Ubuntu but broke Mac.
punya pushed a commit to punya/opentelemetry-collector-contrib that referenced this pull request Jul 21, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants