chore: fix prometheus remote write exporter not setting timestamp on created metric #29503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Nov 28, 2023
Aneurysm9
approved these changes
Nov 29, 2023
dashpole
added
bug
codeboten
approved these changes
Dec 6, 2023
jmichalek132
deleted the
jm-fix-prometheus-remote-write-set-timestamp-created-metric
branch
jayasai470
pushed a commit
to jayasai470/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2023
…created metric (open-telemetry#29503) As disucssed on cncf [slack](https://cloud-native.slack.com/archives/C01LSCJBXDZ/p1700938910822949) fixing the issue with _created metrics where prometheus backend refuses it due to "too old" due to not setting a timestamp for the sample created. The timestamp used is the timestamp for the original sample the correspondent _created metrics is generated for. **Link to tracking Issue:** open-telemetry#24915 Tested locally with prometheus compatible backend. --------- Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: David Ashpole <dashpole@google.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As disucssed on cncf slack fixing the issue with _created metrics where prometheus backend refuses it due to "too old" due to not setting a timestamp for the sample created. The timestamp used is the timestamp for the original sample the correspondent _created metrics is generated for.
Link to tracking Issue: #24915
Testing:
Tested locally with prometheus compatible backend.
Documentation: