Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/azuremonitor] Enhance AAD Documentation. #29234

Merged
merged 11 commits into from
Nov 16, 2023
Merged

[exporter/azuremonitor] Enhance AAD Documentation. #29234

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dc7b9f9
Enhance AAD Documentation.
rajkumar-rangaraj Nov 13, 2023
5a7ebac
Merge branch 'main' into rajrang/aadEnhance
rajkumar-rangaraj Nov 13, 2023
a06596e
test changes
rajkumar-rangaraj Nov 13, 2023
e8d48b9
Merge remote-tracking branch 'origin/main' into rajrang/aadEnhance
rajkumar-rangaraj Nov 13, 2023
e14e3f2
Merge branch 'rajrang/aadEnhance' of github.com:rajkumar-rangaraj/ope…
rajkumar-rangaraj Nov 13, 2023
d6f801e
Remove instrumentation key based sentence.
rajkumar-rangaraj Nov 13, 2023
d08ff9f
Empty Commit to rerun CI
rajkumar-rangaraj Nov 13, 2023
9a0fd28
Merge branch 'main' into rajrang/aadEnhance
rajkumar-rangaraj Nov 14, 2023
11e08c5
Merge branch 'main' into rajrang/aadEnhance
rajkumar-rangaraj Nov 16, 2023
1504624
Add changelog
rajkumar-rangaraj Nov 16, 2023
85e7aa9
Merge branch 'main' into rajrang/aadEnhance
rajkumar-rangaraj Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test changes
  • Loading branch information
@rajkumar-rangaraj
rajkumar-rangaraj committed Nov 13, 2023
commit a06596e68733ac11e9fa71be6eda501c2af696cf
10 changes: 5 additions & 5 deletions exporter/azuremonitorexporter/connection_string_parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func TestParseConnectionString(t *testing.T) {
},
want: &ConnectionVars{
InstrumentationKey: "00000000-0000-0000-0000-000000000000",
IngestionURL: "https://ingestion.azuremonitor.com/v2/track",
IngestionURL: "https://ingestion.azuremonitor.com/v2.1/track",
},
wantError: false,
},
Expand All @@ -38,7 +38,7 @@ func TestParseConnectionString(t *testing.T) {
},
want: &ConnectionVars{
InstrumentationKey: "00000000-0000-0000-0000-000000000000",
IngestionURL: DefaultIngestionEndpoint + "v2/track",
IngestionURL: DefaultIngestionEndpoint + "v2.1/track",
},
wantError: false,
},
Expand All @@ -49,7 +49,7 @@ func TestParseConnectionString(t *testing.T) {
},
want: &ConnectionVars{
InstrumentationKey: "00000000-0000-0000-0000-000000000000",
IngestionURL: "https://ingestion.azuremonitor.com/v2/track",
IngestionURL: "https://ingestion.azuremonitor.com/v2.1/track",
},
wantError: false,
},
Expand Down Expand Up @@ -93,7 +93,7 @@ func TestParseConnectionString(t *testing.T) {
},
want: &ConnectionVars{
InstrumentationKey: "00000000-0000-0000-0000-000000000000",
IngestionURL: "https://ingestion.azuremonitor.com/v2/track",
IngestionURL: "https://ingestion.azuremonitor.com/v2.1/track",
},
wantError: false,
},
Expand All @@ -104,7 +104,7 @@ func TestParseConnectionString(t *testing.T) {
},
want: &ConnectionVars{
InstrumentationKey: "00000000-0000-0000-0000-000000000000",
IngestionURL: "https://ingestion.azuremonitor.com/v2/track",
IngestionURL: "https://ingestion.azuremonitor.com/v2.1/track",
},
wantError: false,
},
Expand Down