Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix delete_matching_keys examples on docs #29094

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix delete_matching_keys examples on docs #29094

merged 2 commits into from
Nov 14, 2023

Conversation

bmbferreira
Copy link
Contributor

Description: Fix the examples for the delete_matching_keys ottl function

Link to tracking Issue: N/A

Testing: N/A

Documentation: minor for fox the delete_matching_keys since they were referring to the delete_key function

@bmbferreira bmbferreira requested a review from a team November 10, 2023 01:00
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 10, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bmbferreira / name: Bruno Ferreira (1839e2b)
  • ✅ login: TylerHelmuth / name: Tyler Helmuth (6ccac34)

@songy23 songy23 added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry labels Nov 10, 2023
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Nov 11, 2023
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Closed
@codeboten codeboten added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Nov 14, 2023
@codeboten codeboten merged commit 3755f73 into open-telemetry:main Nov 14, 2023
94 of 96 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
@bmbferreira bmbferreira deleted the fix/delete_matching_keys-example-on-docs branch November 14, 2023 16:01
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@bmbferreira @TylerHelmuth @RoryCrispin
fix delete_matching_keys examples on docs (open-telemetry#29094)
1de1a4c 
**Documentation:** minor for fox the `delete_matching_keys` since they
were referring to the `delete_key` function

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@songy23 songy23 songy23 approved these changes

@codeboten codeboten codeboten approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

Assignees

@TylerHelmuth TylerHelmuth

Labels
documentation Improvements or additions to documentation pkg/ottl ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bmbferreira @codeboten @songy23 @TylerHelmuth