UDP-receiver - improve high-scale performance by skipping usage of decoder when nop encoding is defined #28901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovavza
changed the title
|
@MovieStoreGuy @djaglowski what do you think about this PR? |
djaglowski
approved these changes
Nov 14, 2023
djaglowski
added
the
ready to merge
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…coder when nop encoding is defined (open-telemetry#28901) **Description:** Enhancement - In udp receiver (stanza operator), change handleMessage not to call decode method in case nop encoding is defined, as it's unnecessary. This improves performance in high scale scenarios by reducing memory allocations. **Link to tracking Issue:** <28899 **Testing:** Ran existing unitests. Ran ran stress tests (sending 250k udp packets per second) - memory allocation reduced by 10-20%. **Documentation:** None
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Enhancement - In udp receiver (stanza operator), change handleMessage not to call decode method in case nop encoding is defined, as it's unnecessary.
This improves performance in high scale scenarios by reducing memory allocations.
Link to tracking Issue: <28899
Testing: Ran existing unitests.
Ran ran stress tests (sending 250k udp packets per second) - memory allocation reduced by 10-20%.
Documentation: None