Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awss3exporter] Add the ability to assume the role provided by s3uploader.role_arn #28674

Merged
merged 6 commits into from
Oct 31, 2023
Merged

[exporter/awss3exporter] Add the ability to assume the role provided by s3uploader.role_arn #28674

merged 6 commits into from
Oct 31, 2023

Conversation

thomasbaldwin
Copy link
Contributor

@thomasbaldwin thomasbaldwin commented Oct 27, 2023 •
edited by atoulme
Loading

Description:

Adding a feature - This feature allows role assumption for s3 exportation. It is especially useful on Kubernetes clusters that are using IAM roles for service accounts

Testing:

Deployed to a Kubernetes cluster as well as an EC2 instance and verified it would assume the correct role and publish logs to the respective s3 bucket.

Documentation:

README updated

@thomasbaldwin thomasbaldwin requested a review from a team October 27, 2023 18:14
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 27, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@thomasbaldwin thomasbaldwin changed the title [exporter/awss3exporter] Add the ability to assume the role provided by s3uploader:.role_arn [exporter/awss3exporter] Add the ability to assume the role provided by s3uploader.role_arn Oct 27, 2023
@atoulme
Copy link
Contributor

atoulme commented Oct 27, 2023 •
edited
Loading

Thank you for your contribution! Please follow the following instructions:

  • From the exporter/awss3 folder, please type make tidy
  • From the root of the repository, please type make chlog-new. Please fill in the changelog with information, including an issue related to the work you are performing. You can use this PR number as issue.
  • I also expect our CLA check will ask you to accept our contributor license agreement. Please follow prompts.

@thomasbaldwin
Copy link
Contributor Author

thomasbaldwin commented Oct 27, 2023 •
edited by atoulme
Loading

Thank you for your contribution! Please follow the following instructions:

  • From the exporter/awss3 folder, please type make tidy
  • From the root of the repository, please type make chlog-new. Please fill in the changelog with information, including an issue related to the work you are performing. You can use this PR number as issue.
  • I also expect our CLA check will ask you to accept our contributor license agreement. Please follow prompts.

thanks @atoulme! updated as well as added some tests!

@thomasbaldwin
Copy link
Contributor Author

hey @fatsheep9146! would you like me to keep updating the branch to keep in sync with main for merge, or is that something the reviewer who merges typically will handle?

@thomasbaldwin
Copy link
Contributor Author

hey @songy23, sorry to bother, but any chance you would be able to help me out to get this merged in?

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Oct 31, 2023
@songy23
Copy link
Member

songy23 commented Oct 31, 2023

@open-telemetry/collector-contrib-maintainer this should be good to go 🙏

@mx-psi mx-psi merged commit 5018ac3 into open-telemetry:main Oct 31, 2023
84 of 87 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 31, 2023
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
@thomasbaldwin @jmsnll
[exporter/awss3exporter] Add the ability to assume the role provided …
0bf5b44 
…by s3uploader.role_arn (open-telemetry#28674)

**Description:** <Describe what has changed.>

Adding a feature - This feature allows role assumption for s3
exportation. It is especially useful on Kubernetes clusters that are
using [IAM roles for service
accounts](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html)

**Testing:**

Deployed to a Kubernetes cluster as well as an EC2 instance and verified
it would assume the correct role and publish logs to the respective s3
bucket.

**Documentation:**

README updated
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
@thomasbaldwin @RoryCrispin
[exporter/awss3exporter] Add the ability to assume the role provided …
3ba580c 
…by s3uploader.role_arn (open-telemetry#28674)

**Description:** <Describe what has changed.>

Adding a feature - This feature allows role assumption for s3
exportation. It is especially useful on Kubernetes clusters that are
using [IAM roles for service
accounts](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html)

**Testing:**

Deployed to a Kubernetes cluster as well as an EC2 instance and verified
it would assume the correct role and publish logs to the respective s3
bucket.

**Documentation:**

README updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@SkylerRogers SkylerRogers SkylerRogers approved these changes

@atoulme atoulme atoulme approved these changes

Assignees

@fatsheep9146 fatsheep9146

Labels
exporter/awss3 ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@thomasbaldwin @atoulme @songy23 @SkylerRogers @mx-psi @fatsheep9146