Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving fluentextension to contrib repo. #2794

Merged
merged 7 commits into from
Mar 22, 2021
Merged

Conversation

evkuzin
Copy link
Contributor

@evkuzin evkuzin commented Mar 19, 2021

Description: Fluentbit Extension migration from the core to the contrib repo

Link to tracking Issue: 2674

Testing: whole fluent bit extension without changes was moved. All tests succeed locally

@evkuzin evkuzin requested a review from a team March 19, 2021 20:38
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 19, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #2794 (3af8bcf) into main (4013aed) will decrease coverage by 0.00%.
The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2794      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.01%     
==========================================
  Files         447      450       +3     
  Lines       22077    22184     +107     
==========================================
+ Hits        20216    20313      +97     
- Misses       1392     1398       +6     
- Partials      469      473       +4     
Flag Coverage Δ
integration 69.09% <ø> (ø)
unit 90.50% <92.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
extension/fluentbitextension/process.go 91.57% <91.57%> (ø)
extension/fluentbitextension/factory.go 100.00% <100.00%> (ø)
extension/fluentbitextension/process_linux.go 100.00% <100.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4013aed...3af8bcf. Read the comment docs.

@evkuzin
Copy link
Contributor Author

evkuzin commented Mar 20, 2021

Only windows tests are failing. AFAIK Windows could restrict ports for some reasons

netsh interface ipv4 show excludedportrange protocol=tcp

could provide more info. Probably thats the reason for failing windows tests

@evkuzin
Copy link
Contributor Author

evkuzin commented Mar 20, 2021

@bogdandrutu Thank you for checking it out on a weekend man!
But it still blocked by codecov :(

@bogdandrutu bogdandrutu merged commit 5d313ce into open-telemetry:main Mar 22, 2021
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
* Moving fluentextension to contrib repo.

* go mod file for fluentbitextension

* fix mod file

* fix imports
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants