Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/pdatatest] Ignore span timestamps #27798

Merged

Conversation

sakulali
Copy link
Contributor

@sakulali sakulali commented Oct 17, 2023

Description:
Support ignore timestamps in span comparisons for pdatatest.

Link to tracking Issue:
#27688

Testing:
make chlog-validate
go test for pkg/pdatatest

Documentation:
Add usage for ptracetest.IgnoreStartTimestamp() and ptracetest.IgnoreEndTimestamp()

@dmitryax dmitryax merged commit c878560 into open-telemetry:main Oct 17, 2023
84 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 17, 2023
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Oct 18, 2023
**Description:** 
Support ignore timestamps in span comparisons for pdatatest.

**Link to tracking Issue:** 

open-telemetry#27688

**Testing:**
make chlog-validate
go test for pkg/pdatatest

**Documentation:**
Add usage for `ptracetest.IgnoreStartTimestamp()` and
`ptracetest.IgnoreEndTimestamp()`
sigilioso pushed a commit to carlossscastro/opentelemetry-collector-contrib that referenced this pull request Oct 27, 2023
**Description:** 
Support ignore timestamps in span comparisons for pdatatest.

**Link to tracking Issue:** 

open-telemetry#27688

**Testing:**
make chlog-validate
go test for pkg/pdatatest

**Documentation:**
Add usage for `ptracetest.IgnoreStartTimestamp()` and
`ptracetest.IgnoreEndTimestamp()`
@sakulali sakulali deleted the fix-pdatatest-span-timestamps branch November 2, 2023 13:57
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this pull request Nov 12, 2023
**Description:** 
Support ignore timestamps in span comparisons for pdatatest.

**Link to tracking Issue:** 

open-telemetry#27688

**Testing:**
make chlog-validate
go test for pkg/pdatatest

**Documentation:**
Add usage for `ptracetest.IgnoreStartTimestamp()` and
`ptracetest.IgnoreEndTimestamp()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants