Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a translator for api/v0.2/traces protocol #27672

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Add a translator for api/v0.2/traces protocol #27672

merged 3 commits into from
Nov 20, 2023

Conversation

tomert-alma
Copy link
Contributor

@tomert-alma tomert-alma commented Oct 14, 2023

Description: fixing #27045.
Fixing datadog receiver to listen to api/v0.2/traces api.
Link to tracking Issue: #27045

Testing: add a a UT to datadog translator for api/v0.2/traces

This translator relies on the receiver of datadog agent:
https://github.com/DataDog/datadog-agent/blob/2973404818f6cf02138a5ae3ac9019c342adce38/test/integration/serverless/recorder-extension/main.go#L257

E2E tests has been done, where datadog receiver gets traces from the datadog agent.

@tomert-alma tomert-alma requested a review from a team October 14, 2023 22:22
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jpkrohling
Copy link
Member

jpkrohling commented Oct 24, 2023

@tomert-alma, thank you! Can you add a changelog entry?

@jpkrohling jpkrohling linked an issue Oct 24, 2023 that may be closed by this pull request
@tomert-alma
Copy link
Contributor Author

@jpkrohling done.
@MovieStoreGuy a kindly ping about this PR, can you please take a look?

change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: datadogereceiver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
component: datadogereceiver
component: datadogreceiver

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@tomert-alma
Copy link
Contributor Author

@jpkrohling it says that Im not authorized to merge this pull request.
can you please merge it to main?

thanks!

@tomert-alma
Copy link
Contributor Author

@jpkrohling a kindly ping :)
can you please merge it to main?

@jpkrohling jpkrohling merged commit dae730c into open-telemetry:main Nov 20, 2023
82 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 20, 2023
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
**Description:** fixing open-telemetry#27045.
Fixing datadog receiver to listen to api/v0.2/traces api. 
**Link to tracking Issue:** open-telemetry#27045

**Testing:** add a a UT to datadog translator for  api/v0.2/traces 

This translator relies on the receiver of datadog agent:

https://github.com/DataDog/datadog-agent/blob/2973404818f6cf02138a5ae3ac9019c342adce38/test/integration/serverless/recorder-extension/main.go#L257

E2E tests has been done, where datadog receiver gets traces from the
datadog agent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept data from datadog agent
3 participants