[exporter/syslog] send messages in batches #27661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
force-pushed
the
syslog-exporter-single-request
branch
2 times, most recently
from
4f04944 to
ac5eca4
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
This reverts commit 6b3c288.
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
This changes the behavior of the Syslog exporter to send all logs in a single request instead of sending each syslog message in a separate request and closing the connection after each message. This also significantly refactors (and hopefully simplifies) the exporter's code, extracting the code that formats the Syslog messages from the `sender` type into separate `formatter` types. Hopefully this will make the development of this component easier.
andrzej-stencel
force-pushed
the
syslog-exporter-single-request
branch
from
ac5eca4 to
996afff
Compare
|
Closing this in favor of #27799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds upon #27464 that adds integration tests and fixes some Syslog message formatting bugs.
Description:
This changes the behavior of the Syslog exporter to each batch of Syslog messages in a single request (separated by newlines), instead of sending each message in a separate request and closing the connection after each message.
This also significantly refactors (and hopefully simplifies) the exporter's code, extracting the code that formats the Syslog messages from the
sendertype into separateformattertypes. Hopefully this will make the development of this component easier.Link to tracking Issue:
Testing:
The unit tests have been updated to reflect the refactored codebase. The integration tests introduced in #27464 are unchanged, as the format of the output messages hasn't changed.
Documentation:
No documentation updates.