Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/jaeger] mark featuregates as stable #27636

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Oct 11, 2023

This allows us to remove the deprecated modules. Pinging @frzifus as the original author

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to wait? Since the featuregate never worked.

@codeboten
Copy link
Contributor Author

@frzifus it does, i meant to leave this as a draft to see if some of the other deps can be updated once this is removed

@codeboten codeboten marked this pull request as draft October 11, 2023 21:42
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@MovieStoreGuy
Copy link
Contributor

Does it make sense to wait? Since the featuregate never worked.

Is there anything you wanted to wait for?

@dmitryax
Copy link
Member

dmitryax commented Nov 3, 2023

@frzifus can you please clarify why the feature gate never worked?

@frzifus
Copy link
Member

frzifus commented Nov 3, 2023

Sure, the gate is evaluated inside the factory function. Since this function is called right at the beginning when the collector starts, the command line arguments are not parsed. Therefore its always "disabled".

It should be fixed once open-telemetry/opentelemetry-collector#8478 is merged.

cc @dmitryax

@codeboten
Copy link
Contributor Author

@frzifus now that 0.89.0 is out and the feature gate issue has been addressed, should this PR be revived for the next release?

@frzifus
Copy link
Member

frzifus commented Nov 20, 2023

sure, since it does not work for so long, it should be removed in 0.91.0, right?

@codeboten codeboten force-pushed the codeboten/rm-deprecatedjaegermods branch from 855c36c to b25c615 Compare November 30, 2023 19:17
@codeboten codeboten marked this pull request as ready for review November 30, 2023 19:18
@codeboten
Copy link
Contributor Author

with v0.90.0 out, this should be good to go now. @frzifus @dmitryax

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thx!

Alex Boten added 2 commits December 5, 2023 08:45
This allows us to remove the deprecated modules.

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@atoulme
Copy link
Contributor

atoulme commented Dec 5, 2023

panic: no removal version set for Stable gate "receiver.jaegerreceiver.replaceThriftWithProto"

Alex Boten added 2 commits December 5, 2023 09:52
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codeboten codeboten merged commit 4c16e26 into open-telemetry:main Dec 5, 2023
83 checks passed
@codeboten codeboten deleted the codeboten/rm-deprecatedjaegermods branch December 5, 2023 21:40
@github-actions github-actions bot added this to the next release milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants