-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/jaeger] mark featuregates as stable #27636
[receiver/jaeger] mark featuregates as stable #27636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to wait? Since the featuregate never worked.
@frzifus it does, i meant to leave this as a draft to see if some of the other deps can be updated once this is removed |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Is there anything you wanted to wait for? |
@frzifus can you please clarify why the feature gate never worked? |
Sure, the gate is evaluated inside the factory function. Since this function is called right at the beginning when the collector starts, the command line arguments are not parsed. Therefore its always "disabled". It should be fixed once open-telemetry/opentelemetry-collector#8478 is merged. cc @dmitryax |
@frzifus now that 0.89.0 is out and the feature gate issue has been addressed, should this PR be revived for the next release? |
sure, since it does not work for so long, it should be removed in 0.91.0, right? |
855c36c
to
b25c615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thx!
This allows us to remove the deprecated modules. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
f93347c
to
7b75645
Compare
Signed-off-by: Alex Boten <aboten@lightstep.com>
|
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This allows us to remove the deprecated modules. Pinging @frzifus as the original author