[extension/storage/filestorage] Add bbolt FSync as a config option #27459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Oct 9, 2023
djaglowski
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Thanks for the contribution @natbur.
This looks good to me. However, we'll need accompanying documentation changes. Do you mind updating the readme to include an explanation of the parameter?
|
Readme updated |
djaglowski
approved these changes
Oct 13, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
…pen-telemetry#27459) Description: Exposes bbolt fsync as a configuration option Link to tracking Issue: [20266](open-telemetry#20266) Testing: Manual Testing, Updated unit tests for factory and client Documentation: Added change-log and documentation comments in config.go --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…pen-telemetry#27459) Description: Exposes bbolt fsync as a configuration option Link to tracking Issue: [20266](open-telemetry#20266) Testing: Manual Testing, Updated unit tests for factory and client Documentation: Added change-log and documentation comments in config.go --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Exposes bbolt fsync as a configuration option
Link to tracking Issue: 20266
Testing: Manual Testing, Updated unit tests for factory and client
Documentation: Added change-log and documentation comments in config.go