Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host.name label is hostname is present in node. #2711

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

kisieland
Copy link
Contributor

Description:
Fixes: #2710

Testing:
I've run go test ./... in the changed exporter

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2711 (beb54b9) into main (4013aed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2711   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         447      447           
  Lines       22077    22085    +8     
=======================================
+ Hits        20216    20224    +8     
  Misses       1392     1392           
  Partials      469      469           
Flag Coverage Δ
integration 69.09% <ø> (ø)
unit 90.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/googlecloudexporter/googlecloud.go 78.70% <100.00%> (+1.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4013aed...beb54b9. Read the comment docs.

@dashpole
Copy link
Contributor

In an ideal world, we would change the go exporter to look in the node identifier instead of the resource label (also, why does the node resource label exist if the node identifier should be used instead?). However, i'm concerned that it would change behavior for existing OC stackdriver users. If they are setting host.name, we might change the host it is associated with. Given that the change is isolated to the SD exporter, and reverts back to previous behavior, I think this is probably the best thing to do.

@kisieland
Copy link
Contributor Author

@bogdandrutu PTAL

@kisieland kisieland force-pushed the add-host-name-to-labels branch from c85743a to c484886 Compare March 22, 2021 11:53
@kisieland kisieland force-pushed the add-host-name-to-labels branch from c484886 to beb54b9 Compare March 22, 2021 13:04
@tigrannajaryan tigrannajaryan merged commit 73d1afa into open-telemetry:main Mar 22, 2021
@kisieland kisieland deleted the add-host-name-to-labels branch March 29, 2021 09:17
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Fixes: #2710 

**Testing:**
I've run `go test ./...` in the changed exporter
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing host.name label in googlecloud exporter
4 participants