-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host.name label is hostname is present in node. #2711
Add host.name label is hostname is present in node. #2711
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2711 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 447 447
Lines 22077 22085 +8
=======================================
+ Hits 20216 20224 +8
Misses 1392 1392
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In an ideal world, we would change the go exporter to look in the node identifier instead of the resource label (also, why does the node resource label exist if the node identifier should be used instead?). However, i'm concerned that it would change behavior for existing OC stackdriver users. If they are setting host.name, we might change the host it is associated with. Given that the change is isolated to the SD exporter, and reverts back to previous behavior, I think this is probably the best thing to do. |
@bogdandrutu PTAL |
c85743a
to
c484886
Compare
c484886
to
beb54b9
Compare
Fixes: #2710 **Testing:** I've run `go test ./...` in the changed exporter
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Description:
Fixes: #2710
Testing:
I've run
go test ./...
in the changed exporter