-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/pulsar] do not expose method #27029
Changes from 10 commits
a33a352
cd82574
bfa629f
8fec15c
fa11902
91c0217
7d602b4
7a5decd
2ca9339
0e30c99
bdde4dc
18e506c
d5b1e3b
73cfe45
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: breaking | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) | ||
component: pulsarreceiver | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Do not export the function `WithLogsUnmarshalers`, `WithMetricsUnmarshalers`, `WithTracesUnmarshalers` and pass checkapi. | ||
|
||
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
issues: [26304] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# If your change doesn't affect end users or the exported elements of any package, | ||
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [api] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,33 +26,6 @@ const ( | |
// FactoryOption applies changes to PulsarExporterFactory. | ||
type FactoryOption func(factory *pulsarReceiverFactory) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @atoulme, looks like the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes it is. For now, the checkapi tool only checks functions, not types. We can add that next but it's more complicated, as Config structs must be exported. |
||
|
||
// WithTracesUnmarshalers adds Unmarshalers. | ||
func WithTracesUnmarshalers(tracesUnmarshalers ...TracesUnmarshaler) FactoryOption { | ||
return func(factory *pulsarReceiverFactory) { | ||
for _, unmarshaler := range tracesUnmarshalers { | ||
factory.tracesUnmarshalers[unmarshaler.Encoding()] = unmarshaler | ||
} | ||
} | ||
} | ||
|
||
// WithMetricsUnmarshalers adds MetricsUnmarshalers. | ||
func WithMetricsUnmarshalers(metricsUnmarshalers ...MetricsUnmarshaler) FactoryOption { | ||
return func(factory *pulsarReceiverFactory) { | ||
for _, unmarshaler := range metricsUnmarshalers { | ||
factory.metricsUnmarshalers[unmarshaler.Encoding()] = unmarshaler | ||
} | ||
} | ||
} | ||
|
||
// WithLogsUnmarshalers adds LogsUnmarshalers. | ||
func WithLogsUnmarshalers(logsUnmarshalers ...LogsUnmarshaler) FactoryOption { | ||
return func(factory *pulsarReceiverFactory) { | ||
for _, unmarshaler := range logsUnmarshalers { | ||
factory.logsUnmarshalers[unmarshaler.Encoding()] = unmarshaler | ||
} | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure about this removal. This can be actually used along with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sorry, i made a mistake again and accidentally deleted a feature with |
||
// NewFactory creates Pulsar receiver factory. | ||
func NewFactory(options ...FactoryOption) receiver.Factory { | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is removing the methods altogether, not just making them private
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i wrote an incorrect description, thanks for reviews @codeboten!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done