Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rule expression to match endpoint types for receiver creator #2661

Merged
merged 7 commits into from
Mar 23, 2021
+47 −54
Merged

Change rule expression to match endpoint types for receiver creator #2661

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4154d4b
Change type.pod to type == "pod" in receiver_creator
bjsignalfx Mar 11, 2021
8106c65
Fix failing unit test
bjsignalfx Mar 11, 2021
54c2103
Fix lint error
bjsignalfx Mar 12, 2021
d5e73af
Change receiver creator config rules for port and hostport
bjsignalfx Mar 22, 2021
ad16312
Merge branch 'main' into rule-var
bjsignalfx Mar 23, 2021
06a5bd8
Fix broken unit test
bjsignalfx Mar 23, 2021
d1621fe
Update receiver/receivercreator/observerhandler_test.go
bjsignalfx Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint error
  • Loading branch information
@bjsignalfx
bjsignalfx committed Mar 12, 2021
commit 54c2103631f38cc4d6886894a637aeeb8e7b3d09
2 changes: 1 addition & 1 deletion extension/observer/endpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (e *Endpoint) Env() (EndpointEnv, error) {
env["endpoint"] = e.Target

if e.Details.Type() == PodType {
env["type"] = string(e.Details.Type())
env["type"] = string(PodType)
return env, nil
}

Expand Down
2 changes: 1 addition & 1 deletion extension/observer/endpoints_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestEndpointEnv(t *testing.T) {
},
},
want: EndpointEnv{
"type": "pod",
"type": "pod",
"endpoint": "192.68.73.2",
"name": "pod_name",
"labels": map[string]string{
Expand Down