Add brokers metrics and metrics metadata to Kafkametrics #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.02%
==========================================
Files 435 435
Lines 21620 21628 +8
==========================================
+ Hits 19762 19774 +12
+ Misses 1391 1387 -4
Partials 467 467
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jrcamp
reviewed
Mar 16, 2021
jrcamp
approved these changes
Mar 16, 2021
bogdandrutu
reviewed
Mar 17, 2021
|
Will this be merged regardless of the failing test? - the cause of the failure doesn't seem to be related to any of the changes in this PR. |
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
* add brokers metrics and metrics metadata * update metric names * fix metric units * update offset unit * remove nocover file * empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds the metric code for the brokers scraper. Currently only one metric is reported: the number of brokers.
Follow up to #2620
The complete metadata.yaml and generated_metrics.go file for metrics of consumer groups and topics/partitions, that will be added in subsequent PRs is also included as well as the
Testing: unit tests