[exporter/opensearch] Schema fix in sso_model #26372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
Signed-off-by: acarbonetto <andrewc@bitquilltech.com>
YANG-DB
approved these changes
Sep 11, 2023
|
@acarbonetto could you help address the failing test cases? Updating from main will address |
| @@ -194,6 +194,15 @@ func responseAsError(item opensearchutil.BulkIndexerResponseItem) error { | |||
| return errors.New(string(errorJSON)) | |||
| } | |||
|
|
|||
| func attributesToMapString(attributes pcommon.Map) map[string]string { | |||
There was a problem hiding this comment.
While this function looks relatively harmless, could we still see a few unit tests added for it?
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes issue found in #24540
The exported JSON was rejected by the inbound service because the JSON did not match the ss4o schema. To fix, converted an attribute from array of strings to a joined string.
Link to tracking Issue:
#23611
Testing:
Documentation:
None. Exporter now works as expected.