Snmpreceiver fix counter64 #26368
Merged
Snmpreceiver fix counter64 #26368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t handeled. Internally we convert all numerical SNMP values to an int64. The conversion for a uint64, sent by the newly supported Conter64 SNMP data type, to int64 was lacking and is intruduced with this commit.
technimad-splunk
changed the title
atoulme
reviewed
Sep 1, 2023
|
failed unit test should be fixed @technimad-splunk |
|
I'm still working on the tests. |
…rted float instead.
Test are green now. Fixed by ed97de1 |
fatsheep9146
approved these changes
Sep 4, 2023
djaglowski
reviewed
Sep 5, 2023
| @@ -513,7 +513,7 @@ func TestGetScalarData(t *testing.T) { | |||
| expectedSNMPData := []SNMPData{} | |||
| mockGoSNMP := new(mocks.MockGoSNMPWrapper) | |||
| pdu1 := gosnmp.SnmpPDU{ | |||
| Value: uint64(math.MaxUint64), | |||
| Value: float64(math.MaxFloat64), | |||
There was a problem hiding this comment.
This is a test for an invalid data type.
If we receive an invalid or unsopported data type an error should be raised.
With this PR, uint64 becomes supported, and no error is raised anymore, causing the test to fail.
This change tests for an other, yet unsupported, data type (float64) which should generate an error.
There was a problem hiding this comment.
Ah, missed the context. Thanks for explaining.
djaglowski
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
SNMP data with type Counter64 can be sent as a uint64. This type wasn't handled.
Internally we convert all numerical SNMP values to an int64.
The conversion for a uint64, sent by the newly supported Conter64 SNMP data type, to int64
was lacking and is introduced with this PR.
Link to tracking Issue:
#23897, PR #26119
Testing:
Ran the collector with a config to collect oid 1.3.6.1.2.1.31.1.1.1.6, which is a Counter64.
This didn't work, showed value type as unsupported.
After the change data from this oid comes in as expected.
Documentation: n/a