-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/k8scluster] Add Node resource attributes #26351
[receiver/k8scluster] Add Node resource attributes #26351
Conversation
522a66f
to
34cb775
Compare
34cb775
to
ff81c6e
Compare
k8s.kubelet.version: | ||
description: The version of Kubelet running on the node. | ||
type: string | ||
enabled: false | ||
|
||
k8s.kubeproxy.version: | ||
description: The version of Kube Proxy running on the node. | ||
type: string | ||
enabled: false | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these be added to all metrics or only node metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only node metrics, I think it's same as other resource attributes are added only to the relevant metrics.
Example:
resource_attributes:
k8s.hpa.name:
description: The k8s hpa name.
type: string
enabled: true
k8s.job.name:
description: The k8s pod name.
type: string
enabled: true
@@ -1,6 +1,5 @@ | |||
// Copyright The OpenTelemetry Authors | |||
// SPDX-License-Identifier: Apache-2.0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: unrelated removal. We usually keep a space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks for review!
ff81c6e
to
a8c9b05
Compare
Description:
Add optional k8s.kubelet.version, k8s.kubeproxy.version node resource attributes
Doing some actual testing with kind with k8s_cluster receiver and prometheus exporters.
and prometheus exporter:
Example metric:
Link to tracking Issue:
#24835
Testing:
Documentation: