[chore][fileconsumer] Remove generation field from reader #25897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fileconsumer
package remembers all files it has seen for a short period of time. This ensures that we do not double-ingest files in the rare case where a file "temporarily disappears", such as may happen when with a file rotation strategy that involves use of a temp file name that is outside the include glob. In such cases, we may know of a file during one poll interval, then subsequently fail to find it in the next, then find it again in the next.We manage this short-term memory by remember files for a given number of poll intervals, currently hardcoded to 3. This PR restructures the way that we manage these generations. Previously, the
reader
struct had a field calledgeneration
, which was incremented when rotating generations. All previously known readers were stored in a single slice, which was appended to and cut as appropriate to rotate the generations.Now, each generation is stored in a separate slice, so we can manage generations without the need to increment or check a
generation
field. This has a couple benefits:[]generation
pattern, vs a[]reader
pattern.