Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafkametricsreceiver initial structure #2550

Merged

Conversation

dshomoye
Copy link
Contributor

@dshomoye dshomoye commented Mar 4, 2021

Description: Adds the factory, config and receiver for new (kafkametricsreceiver) component.

The new kafkametricsreceiver will primarily report metrics on consumer_group lag from kafka (using the internal __consumer_offsets topic). It will also include metrics on number of brokers, topics, and offsets of topics.

Testing: The current code is a scaffolding that cannot be e2e tested, appropriate unit tests were added.

Documentation: README explaining usage of new receiver component is included.

@dshomoye dshomoye requested a review from a team March 4, 2021 00:06
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #2550 (def4bca) into main (a7fbb60) will increase coverage by 22.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2550       +/-   ##
===========================================
+ Coverage   69.18%   91.32%   +22.13%     
===========================================
  Files          34      431      +397     
  Lines        1603    21480    +19877     
===========================================
+ Hits         1109    19616    +18507     
- Misses        420     1395      +975     
- Partials       74      469      +395     
Flag Coverage Δ
integration 69.18% <ø> (ø)
unit 90.22% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/kafkametricsreceiver/factory.go 100.00% <100.00%> (ø)
receiver/kafkametricsreceiver/receiver.go 100.00% <100.00%> (ø)
exporter/signalfxexporter/translation/converter.go 95.26% <0.00%> (ø)
...rcedetectionprocessor/internal/aws/ec2/metadata.go 80.00% <0.00%> (ø)
receiver/k8sclusterreceiver/utils/timeseries.go 100.00% <0.00%> (ø)
...porter/awsprometheusremotewriteexporter/factory.go 100.00% <0.00%> (ø)
receiver/kubeletstatsreceiver/kubelet/network.go 100.00% <0.00%> (ø)
exporter/carbonexporter/exporter.go 79.62% <0.00%> (ø)
exporter/signalfxexporter/hostmetadata/metadata.go 100.00% <0.00%> (ø)
...ceiver/kubeletstatsreceiver/kubelet/accumulator.go 100.00% <0.00%> (ø)
... and 411 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7fbb60...def4bca. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 107e5f3 into open-telemetry:main Mar 8, 2021
@dshomoye dshomoye deleted the receiver/kafkametrics/setup branch March 11, 2021 19:07
kisieland referenced this pull request in kisieland/opentelemetry-collector-contrib Mar 16, 2021
)

Signed-off-by: Granville Schmidt <1246157+gramidt@users.noreply.github.com>
pmatyjasek-sumo referenced this pull request in pmatyjasek-sumo/opentelemetry-collector-contrib Apr 28, 2021
Adds the factory, config and receiver for new (kafkametricsreceiver) component.

The new kafkametricsreceiver will primarily report metrics on consumer_group lag from kafka (using the internal __consumer_offsets topic). It will also include metrics on number of brokers, topics, and offsets of topics.

Testing: The current code is a scaffolding that cannot be e2e tested, appropriate unit tests were added.

Documentation: README explaining usage of new receiver component is included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants