-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kafkametricsreceiver initial structure #2550
Merged
tigrannajaryan
merged 4 commits into
open-telemetry:main
from
dshomoye:receiver/kafkametrics/setup
Mar 8, 2021
Merged
Add kafkametricsreceiver initial structure #2550
tigrannajaryan
merged 4 commits into
open-telemetry:main
from
dshomoye:receiver/kafkametrics/setup
Mar 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2550 +/- ##
===========================================
+ Coverage 69.18% 91.32% +22.13%
===========================================
Files 34 431 +397
Lines 1603 21480 +19877
===========================================
+ Hits 1109 19616 +18507
- Misses 420 1395 +975
- Partials 74 469 +395
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…y-collector-contrib into receiver/kafkametrics/setup
jrcamp
approved these changes
Mar 8, 2021
tigrannajaryan
approved these changes
Mar 8, 2021
This was referenced Mar 15, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
Adds the factory, config and receiver for new (kafkametricsreceiver) component. The new kafkametricsreceiver will primarily report metrics on consumer_group lag from kafka (using the internal __consumer_offsets topic). It will also include metrics on number of brokers, topics, and offsets of topics. Testing: The current code is a scaffolding that cannot be e2e tested, appropriate unit tests were added. Documentation: README explaining usage of new receiver component is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds the factory, config and receiver for new (kafkametricsreceiver) component.
The new
kafkametricsreceiver
will primarily report metrics on consumer_group lag from kafka (using the internal__consumer_offsets
topic). It will also include metrics on number of brokers, topics, and offsets of topics.Testing: The current code is a scaffolding that cannot be e2e tested, appropriate unit tests were added.
Documentation: README explaining usage of new receiver component is included.