Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8sclusterreceiver] add k8s.pod.status_reason optional metric #24764

Merged
merged 2 commits into from
Aug 31, 2023
Merged

[k8sclusterreceiver] add k8s.pod.status_reason optional metric #24764

merged 2 commits into from
Aug 31, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Aug 1, 2023 •
edited
Loading

Description:

add k8s.pod.status_reason optional metric

Link to tracking Issue:

#24034

Testing:

  • added unit test

Documentation:

  • generated docs

@povilasv povilasv changed the title [k8sclusterreceiver] add k8s.pod.status_reason optional metrics [k8sclusterreceiver] add k8s.pod.status_reason optional metric Aug 1, 2023
@github-actions github-actions bot requested a review from dmitryax August 1, 2023 08:33
@povilasv povilasv marked this pull request as ready for review August 1, 2023 10:12
@povilasv povilasv requested a review from a team August 1, 2023 10:12
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Aug 1, 2023
@atoulme atoulme removed the ready to merge Code review completed; ready to merge by maintainers label Aug 1, 2023
atoulme
atoulme previously requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make sure @jinja2's comment is addressed.

@povilasv povilasv force-pushed the k8sclusterreceiver-pod-status-reason branch from 8ab1715 to e1be31e Compare August 14, 2023 08:48
@povilasv povilasv requested a review from atoulme August 14, 2023 11:54
@povilasv
Copy link
Contributor Author

Rebased the PR to accommodate the new changes in main, would appreciate another review

@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Aug 30, 2023
@dmitryax dmitryax merged commit 9b61042 into open-telemetry:main Aug 31, 2023
97 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 31, 2023
@jinja2 jinja2 mentioned this pull request Oct 20, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@atoulme atoulme Awaiting requested review from atoulme

@jinja2 jinja2 Awaiting requested review from jinja2

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
ready to merge Code review completed; ready to merge by maintainers receiver/k8scluster
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
7 participants
@povilasv @atoulme @dmitryax @TylerHelmuth @jinja2 @songy23 @MovieStoreGuy