[processor/resourcedetection] Fix system detector not setting attributes (#24670) #24684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
processor/resourcedetection
|
I was hoping to simply cherry-pick the same commit into the branch, but looks like I can't push it: Is a PR more appropriate? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.82.x #24684 +/- ##
===================================================
+ Coverage 82.93% 82.95% +0.01%
===================================================
Files 1633 1633
Lines 153880 153880
===================================================
+ Hits 127627 127650 +23
+ Misses 22775 22756 -19
+ Partials 3478 3474 -4
☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Jul 31, 2023
dmitryax
merged commit 92b0d3e
into
open-telemetry:release/v0.82.x
269 of 272 checks passed
taj-p
added a commit
to Canva/opentelemetry-collector-contrib
that referenced
this pull request
Oct 10, 2023
* [processor/resourcedetection] Fix system detector not setting attributes (open-telemetry#24670) (open-telemetry#24684) Cherry-pick the commit from the patch release v0.82.1 Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> * feat: working * . * . * . * . * . --------- Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the commit from the patch release v0.82.1