Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[splunkhecreceiver] aligns success response body w/ splunk enterprise #24604

Merged

Conversation

nboshart-splunk
Copy link
Contributor

@nboshart-splunk nboshart-splunk commented Jul 27, 2023

Description: Changed 200 response body from plaintext to JSON object: "OK"{"text": "Success", "code": 0}.

Testing: Updated existing unit tests to reflect the new response body. Everything passes as expected.

Documentation: https://docs.splunk.com/Documentation/Splunk/9.0.4/RESTREF/RESTinput

Link to Tracking Issue: #19219

@nboshart-splunk nboshart-splunk requested a review from a team July 27, 2023 00:02
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@atoulme
Copy link
Contributor

atoulme commented Jul 27, 2023

Thank you! Please sign the CLA. I think the correct issue to link here is #19219

@nboshart-splunk
Copy link
Contributor Author

Thank you! Please sign the CLA. I think the correct issue to link here is #19219

Yup, just caught that as well. Went ahead and updated the description. 👍🏼

@atoulme
Copy link
Contributor

atoulme commented Jul 27, 2023

From past experience the CLA check doesn't always refresh, so you might need to try to open a new PR. Apologies.

@nboshart-splunk
Copy link
Contributor Author

From past experience the CLA check doesn't always refresh, so you might need to try to open a new PR. Apologies.

Ah, that's unfortunate. Based on my conversation with @flands, I need to author the commits using my Splunk email for the CLA check to go through anyway. Going to see if it's possible to do that in this PR; if not, I'll open a new one.

@nboshart-splunk nboshart-splunk force-pushed the dmx3256/hecreceiver-successresp branch from 2cc6e54 to b200c2d Compare July 27, 2023 01:04
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

  • ✅ login: TylerHelmuth / name: Tyler Helmuth (b200c2d9f1e824b03dc66af4727082a5effb8a98)
  • ❌ The email address for the commit (da65559a7cc2c29f266237dabd8048e9e70ef1e5, 27753af0d92bc58eee6d0f36ec47aad9c2081e8d, dc69c24ae78865cc5cef669d8a9123d2f28c105b) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 27, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nichabosh / name: Nicholas Boshart (da65559a7cc2c29f266237dabd8048e9e70ef1e5, 27753af0d92bc58eee6d0f36ec47aad9c2081e8d, dc69c24ae78865cc5cef669d8a9123d2f28c105b, bc54a111d45aff5719b9bda80dc421cf3d7b566a)
  • ✅ login: TylerHelmuth / name: Tyler Helmuth (b200c2d9f1e824b03dc66af4727082a5effb8a98)

@nboshart-splunk
Copy link
Contributor Author

Well that was a fun little back-and-forth with the EasyCLA bot. Looks like everything's ready for review now, @atoulme. 🥳

@atoulme
Copy link
Contributor

atoulme commented Jul 27, 2023

rerunning failing test.

@nboshart-splunk nboshart-splunk force-pushed the dmx3256/hecreceiver-successresp branch from 50ee6e9 to 9939b72 Compare July 27, 2023 20:32
@splunkericl
Copy link
Contributor

@atoulme looks like all tests/checks have passed. Do you think we can merge this in?

@dmitryax dmitryax merged commit 613a43c into open-telemetry:main Aug 1, 2023
90 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 1, 2023
@nboshart-splunk nboshart-splunk deleted the dmx3256/hecreceiver-successresp branch August 1, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants