-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[splunkhecreceiver] aligns success response body w/ splunk enterprise #24604
[splunkhecreceiver] aligns success response body w/ splunk enterprise #24604
Conversation
Thank you! Please sign the CLA. I think the correct issue to link here is #19219 |
Yup, just caught that as well. Went ahead and updated the description. 👍🏼 |
From past experience the CLA check doesn't always refresh, so you might need to try to open a new PR. Apologies. |
Ah, that's unfortunate. Based on my conversation with @flands, I need to author the commits using my Splunk email for the CLA check to go through anyway. Going to see if it's possible to do that in this PR; if not, I'll open a new one. |
2cc6e54
to
b200c2d
Compare
|
Well that was a fun little back-and-forth with the EasyCLA bot. Looks like everything's ready for review now, @atoulme. 🥳 |
rerunning failing test. |
50ee6e9
to
9939b72
Compare
@atoulme looks like all tests/checks have passed. Do you think we can merge this in? |
Description: Changed
200
response body from plaintext to JSON object:"OK"
→{"text": "Success", "code": 0}
.Testing: Updated existing unit tests to reflect the new response body. Everything passes as expected.
Documentation: https://docs.splunk.com/Documentation/Splunk/9.0.4/RESTREF/RESTinput
Link to Tracking Issue: #19219