Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/k8scluster] Change k8s.daemonset metrics to use mdatagen #24269

Merged

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 14, 2023

Description:

Change k8s.daemonset metrics to use mdatagen.

The migration has the following side effects, we add scope and schema to metrics:

    schemaUrl: "https://opentelemetry.io/schemas/1.18.0"
...
        scope:
          name: otelcol/k8sclusterreceiver
          version: latest

Link to tracking Issue:
#10553
#4367

Testing:

  • Updated unit tests

Documentation:

  • Generated docs

@github-actions github-actions bot requested a review from dmitryax July 14, 2023 14:07
@povilasv povilasv force-pushed the k8s-cluster-receiver-daemonset-2 branch 8 times, most recently from e46bf86 to 4e1ea72 Compare July 20, 2023 10:46
@povilasv povilasv marked this pull request as ready for review July 20, 2023 11:09
@povilasv povilasv requested a review from a team July 20, 2023 11:09
@povilasv
Copy link
Contributor Author

Hey, @dmitryax and @crobert-1 this is ready for review.

Unit tests failures are unrelated , (datadogexporter)

ok  	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter/internal/hostmetadata/internal/system	0.037s	coverage: 67.9% of statements
==================
WARNING: DATA RACE
Read at 0x00c00011a863 by goroutine 19:
 ...
FAIL

@povilasv povilasv force-pushed the k8s-cluster-receiver-daemonset-2 branch from 014b304 to 28984ec Compare July 20, 2023 17:23
@povilasv povilasv requested a review from dmitryax July 20, 2023 17:58
@povilasv
Copy link
Contributor Author

@dmitryax updated :)

@dmitryax dmitryax merged commit 0bbc5dd into open-telemetry:main Jul 20, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants