[processor/resourcedetection] Disable host.id on system detector by default #24010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
force-pushed
the
mx-psi/system-detector-host-id
branch
from
7c1d650 to
013a791
Compare
github-actions
bot
added
the
processor/resourcedetection
songy23
approved these changes
Jul 13, 2023
| # you should instead start your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
I wonder whether this is a breaking change or rather a fix to a previous breaking change 🤔
There was a problem hiding this comment.
Since this has been out for a few months now I would rather mark this as breaking in case users have adapted to the new behavior
dmitryax
reviewed
Jul 13, 2023
mx-psi
commented
Jul 13, 2023
dmitryax
approved these changes
Jul 14, 2023
sumo-drosiek
approved these changes
Jul 14, 2023
|
@Aneurysm9 @dashpole @atoulme PTAL! I will merge this Monday EU morning if there are no further comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Disable setting
host.idby default on thesystemdetector.Users can restore the previous behavior by setting
system::resource_attributes::host.id::enabledtotrue.Link to tracking Issue: Fixes #21233
Testing: Amended existing tests