[chore] fix exhaustive lint for processor spanprocessor (#23266) #23952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
changed the title
67 tasks
|
i'm not sure why it's not skipping the changelog step, i have added |
fatsheep9146
added
the
Skip Changelog
atoulme
approved these changes
Jul 9, 2023
|
ping owner for approve @boostchicken |
codeboten
requested changes
Jul 10, 2023
processor/spanprocessor/span.go
Outdated
Comment on lines
145
to
148
| case pcommon.ValueTypeEmpty: | ||
| case pcommon.ValueTypeSlice: | ||
| case pcommon.ValueTypeBytes: | ||
| case pcommon.ValueTypeMap: |
There was a problem hiding this comment.
These should all have fallthrough
There was a problem hiding this comment.
woops my Java is showing. Sorry I missed this.
songy23
added
the
ready to merge
codeboten
approved these changes
Jul 21, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related #23266