[exporter/kafkaexporter] add zipkin encoding for traces #23947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good to me. Please resolve the conflicts. I will take another look and make sure the build runs. |
|
@atoulme thanks for reviewing! Conflicts should be resolved now. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
MovieStoreGuy
approved these changes
Aug 17, 2023
|
@atoulme @MovieStoreGuy are we good to merge this? Just want to avoid it drifting too much from the main branch. |
iblancasa
approved these changes
Sep 7, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
pavolloffay
approved these changes
Sep 22, 2023
atoulme
approved these changes
Sep 28, 2023
|
LGTM please resolve the conflicts sorry, and we can get it merged. |
|
@atoulme done! |
atoulme
added
the
ready to merge
This was referenced Oct 3, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…ry#23947) **Description:** <Describe what has changed.> Adding Zipkin v2 encoding support for traces in kafkaexporter **Link to tracking Issue:** <Issue number if applicable> open-telemetry#21102 **Testing:** <Describe what testing was performed and which tests were added.> Test for `tracesMarshalers` has been extended with zipkin JSON test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding Zipkin v2 encoding support for traces in kafkaexporter
Link to tracking Issue:
#21102
Testing:
Test for
tracesMarshalershas been extended with zipkin JSON test case.